From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965085AbbDXPPg (ORCPT ); Fri, 24 Apr 2015 11:15:36 -0400 Received: from relay.uni-heidelberg.de ([129.206.100.212]:39525 "EHLO relay.uni-heidelberg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbbDXPPf (ORCPT ); Fri, 24 Apr 2015 11:15:35 -0400 X-Greylist: delayed 1997 seconds by postgrey-1.27 at vger.kernel.org; Fri, 24 Apr 2015 11:15:34 EDT Date: Fri, 24 Apr 2015 16:41:58 +0200 From: Hermann Lauer To: Markus Pargmann Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Michal Belczyk Subject: Re: [PATCH v4.0 for testing] nbd: Fix timeout detection Message-ID: <20150424144158.GF30067@lemon.iwr.uni-heidelberg.de> References: <20150423144313.GI19764@lemon.iwr.uni-heidelberg.de> <1429860933-22517-1-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1429860933-22517-1-git-send-email-mpa@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Markus, On Fri, Apr 24, 2015 at 09:35:33AM +0200, Markus Pargmann wrote: > At the moment the nbd timeout just detects hanging tcp operations. This > is not enough to detect a hanging or bad connection as expected of a > timeout. ... > Cc: Michal Belczyk > Cc: Hermann Lauer > Signed-off-by: Markus Pargmann > [mpa: Backported to 4.0] > > Signed-off-by: Markus Pargmann > --- > > This patch is only for testing at the moment. I will backport the final patch > for the stable tree at the end. tested with 4.0 - timeout works as expected after disconnecting the ethernet. No hang or unexpected kernel message. Many thanks and a nice weekend, greetings Hermann -- Netzwerkadministration/Zentrale Dienste, Interdiziplinaeres Zentrum fuer wissenschaftliches Rechnen der Universitaet Heidelberg IWR; INF 368; 69120 Heidelberg; Tel: (06221)54-8236 Fax: -5224 Email: Hermann.Lauer@iwr.uni-heidelberg.de