From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756111AbbDYNBg (ORCPT ); Sat, 25 Apr 2015 09:01:36 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37041 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbbDYNBe (ORCPT ); Sat, 25 Apr 2015 09:01:34 -0400 Date: Sat, 25 Apr 2015 14:01:24 +0100 From: Mark Brown To: Jonatas Rech Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150425130124.GF31708@sirena.org.uk> References: <1429111398-21444-1-git-send-email-jonatas.rech@datacom.ind.br> <20150418125556.GR26185@sirena.org.uk> <363371145.339730.1429715343024.JavaMail.zimbra@datacom.ind.br> <20150422195746.GM22845@sirena.org.uk> <20150423180622.GC12637@datacom.ind.br> <20150424181745.GG22845@sirena.org.uk> <20150424200326.GA14443@datacom.ind.br> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XIiC+We3v3zHqZ6Z" Content-Disposition: inline In-Reply-To: <20150424200326.GA14443@datacom.ind.br> X-Cookie: Swap read error. You lose your mind. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: fsl-espi: fix behaviour for full-duplex xfers X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XIiC+We3v3zHqZ6Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 24, 2015 at 05:03:26PM -0300, Jonatas Rech wrote: > On Fri, Apr 24, 2015 at 07:17:45PM +0100, Mark Brown wrote: > > The commit message says "this correction has exposed an inconsistency" > > which suggests that the problem was masked before this fix. Did you > > mean to say that while fixing this you noticed a separate bug that's > > present anyway? > Exactly. Besides fixing the full-duplex capability I reorganized things > inside the main loop so that anybody can spot where the extra bytes are > being sent, but the code works just the same as before in that respect. OK, please be clear when writing changelogs - it makes life easier. --XIiC+We3v3zHqZ6Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVO5AjAAoJECTWi3JdVIfQ5uwH/AsR2TeDpgNGcG7oASpbx+X0 nTMDnskjHZTJ8l3Wqz5VeFe7mL9wdJZmj7El1mBLlX+j5WT5WjJ4UJJgseEr+1aL Dbn8nhPH7In30UjRWugV9/LZJJ606VzabRnJ2BGq6cWBRg5fwnSXMl09JM8L3rjq qvN4SZMpgPfaNoqYWVUQ75G3TYeEYS+Kz+vyZnx/ixLDwegG9WdaI8ZNJcUPejtR 0m/WhCMktt3MjcG+Eg9I4x5rco70HFMVZkJe8suir+6NfEGqDSZiPN4rZBrg59Wg qZSvyzlmkP/29W/4UfOb0G4mzqrrZS92UH/lquBKSzTABhijr3EijfB7r2nIIhY= =wxuZ -----END PGP SIGNATURE----- --XIiC+We3v3zHqZ6Z--