mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: stripathi@apm.com, linux-kernel@vger.kernel.org,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH v2 1/2] libata: Add helper to determine when PHY events should be ignored
Date: Sat, 25 Apr 2015 16:53:34 -0400	[thread overview]
Message-ID: <20150425205334.GA1499@htj.duckdns.org> (raw)
In-Reply-To: <1429984357-2223-2-git-send-email-gabriele.mzt@gmail.com>

On Sat, Apr 25, 2015 at 07:52:36PM +0200, Gabriele Mazzotta wrote:
> +bool sata_lpm_ignore_phy_events(struct ata_link *link)
> +{
> +	/* if LPM is enabled, PHYRDY doesn't mean anything */
> +	return !!(link->lpm_policy > ATA_LPM_MAX_POWER);

This gets removed by the next patch so it doesn't matter but there's
no need to do !! here.  The expression is already bool and even if not
casting to bool can't yield any other result.

Thanks.

-- 
tejun

  reply	other threads:[~2015-04-25 20:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-25 17:52 [PATCH v2 0/2] libata: Ignore spurious PHY event on LPM policy change Gabriele Mazzotta
2015-04-25 17:52 ` [PATCH v2 1/2] libata: Add helper to determine when PHY events should be ignored Gabriele Mazzotta
2015-04-25 20:53   ` Tejun Heo [this message]
2015-04-25 17:52 ` [PATCH v2 2/2] libata: Ignore spurious PHY event on LPM policy change Gabriele Mazzotta
2015-04-25 20:53   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150425205334.GA1499@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=gabriele.mzt@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stripathi@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome