From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751304AbbDYUyH (ORCPT ); Sat, 25 Apr 2015 16:54:07 -0400 Received: from mail-vn0-f54.google.com ([209.85.216.54]:42014 "EHLO mail-vn0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbbDYUyE (ORCPT ); Sat, 25 Apr 2015 16:54:04 -0400 Date: Sat, 25 Apr 2015 16:53:59 -0400 From: Tejun Heo To: Gabriele Mazzotta Cc: stripathi@apm.com, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH v2 2/2] libata: Ignore spurious PHY event on LPM policy change Message-ID: <20150425205359.GB1499@htj.duckdns.org> References: <1429984357-2223-1-git-send-email-gabriele.mzt@gmail.com> <1429984357-2223-3-git-send-email-gabriele.mzt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429984357-2223-3-git-send-email-gabriele.mzt@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 25, 2015 at 07:52:37PM +0200, Gabriele Mazzotta wrote: > When the LPM policy is set to ATA_LPM_MAX_POWER, the device might > generate a spurious PHY event that cuases errors on the link. > Ignore this event if it occured within 10s after the policy change. > > The timeout was chosen observing that on a Dell XPS13 9333 these > spurious events can occur up to roughly 6s after the policy change. > > Link: http://lkml.kernel.org/g/3352987.ugV1Ipy7Z5@xps13 > Signed-off-by: Gabriele Mazzotta Applied 1-2 to libata/for-4.1-fixes w/ stable cc'd. Thanks a lot. -- tejun