From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751175AbbDYWdK (ORCPT ); Sat, 25 Apr 2015 18:33:10 -0400 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:56255 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbbDYWdF (ORCPT ); Sat, 25 Apr 2015 18:33:05 -0400 Date: Sat, 25 Apr 2015 23:32:47 +0100 From: One Thousand Gnomes To: Sudip Mukherjee Cc: Greg KH , Dan Carpenter , jdelvare@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 WIP 3/3] i2c-parport: modify driver to use new parport device model Message-ID: <20150425233247.3fe61f57@lxorguk.ukuu.org.uk> In-Reply-To: <1429967240-4033-3-git-send-email-sudipm.mukherjee@gmail.com> References: <1429967240-4033-1-git-send-email-sudipm.mukherjee@gmail.com> <1429967240-4033-3-git-send-email-sudipm.mukherjee@gmail.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int parport; > +module_param(parport, int, 0); > +MODULE_PARM_DESC(parport, "The parport to be used, default parport0\n"); Minor suggested enhancement: this ought to be an array so you can attach multiple instances to a system. Alan