From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005AbbDZSdJ (ORCPT ); Sun, 26 Apr 2015 14:33:09 -0400 Received: from smtprelay0080.hostedemail.com ([216.40.44.80]:35551 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751160AbbDZSdH (ORCPT ); Sun, 26 Apr 2015 14:33:07 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2692:2693:3138:3139:3140:3141:3142:3151:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:5007:6119:6120:6261:7576:7875:7903:7904:10004:10400:10848:10967:11026:11232:11658:11914:12043:12114:12291:12438:12517:12519:12683:12740:13069:13311:13357:14095:14096:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bird85_1adaa7b7bcf57 X-Filterd-Recvd-Size: 2139 Date: Sun, 26 Apr 2015 14:33:03 -0400 From: Steven Rostedt To: Xunlei Pang Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Juri Lelli , Ingo Molnar , Xunlei Pang Subject: Re: [RFC PATCH 1/6] sched/rt: Provide new check_preempt_equal_prio_common() Message-ID: <20150426143303.07b62235@gandalf.local.home> In-Reply-To: <1430068258-1960-1-git-send-email-xlpang@126.com> References: <1430068258-1960-1-git-send-email-xlpang@126.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Apr 2015 01:10:53 +0800 Xunlei Pang wrote: > From: Xunlei Pang > > When p is queued, there may be other tasks already queued at the > same priority in the "run queue", so we should peek the most front > one to do the equal priority preemption. > > This patch modifies check_preempt_equal_prio() and provides new > check_preempt_equal_prio_common() to do the common preemption. This change log fails to explain why this is needed. > > There are also other cases to be added calling the new interface > in the following patches. A change log should stand on its own, and not just say, other patches will use it. It can say that, if it fully explains why the change is needed. Also note, you are missing a 0/6 email that explains the entire rational of the patch set, such that people understand more what you intend to accomplish. We have no idea what your overall goal is. -- Steve > > Signed-off-by: Xunlei Pang > --- > kernel/sched/rt.c | 70 ++++++++++++++++++++++++++++++++++++++++++------------- > 1 file changed, 54 insertions(+), 16 deletions(-) >