From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933163AbbD0RX1 (ORCPT ); Mon, 27 Apr 2015 13:23:27 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:56091 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933025AbbD0RXT (ORCPT ); Mon, 27 Apr 2015 13:23:19 -0400 Date: Mon, 27 Apr 2015 13:23:18 -0400 (EDT) Message-Id: <20150427.132318.64451627276298303.davem@davemloft.net> To: m-karicheri2@ti.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface From: David Miller In-Reply-To: <553E6CD7.9040409@ti.com> References: <1429902101-2911-1-git-send-email-m-karicheri2@ti.com> <20150425.154856.1696991150241343700.davem@davemloft.net> <553E6CD7.9040409@ti.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Apr 2015 10:23:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Murali Karicheri Date: Mon, 27 Apr 2015 13:07:35 -0400 > On 04/25/2015 03:48 PM, David Miller wrote: >> From: Murali Karicheri >> Date: Fri, 24 Apr 2015 15:01:41 -0400 >> >>> Currently when interface type is MAC to Phy, netif_carrier_(on/off) >>> is called which is not needed as Phy lib already updates the carrier >>> status to net stack. This is needed only for other interface types >>> >>> Signed-off-by: Murali Karicheri >> >> net-next is not open for submissions yet > David, > > Do I need to re-submit this patch when the net-next gets opened for > this? This is essentially a bug fix and can be applied to current If it's really a bug fix, then you shouldn't target it at net-next. I'll never understand why people do things like this.