From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752338AbbD0FGA (ORCPT ); Mon, 27 Apr 2015 01:06:00 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:35646 "EHLO e28smtp09.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769AbbD0FF4 (ORCPT ); Mon, 27 Apr 2015 01:05:56 -0400 Date: Mon, 27 Apr 2015 10:35:17 +0530 From: "Naveen N. Rao" To: Masami Hiramatsu Cc: Arnaldo Carvalho de Melo , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, mpe@ellerman.id.au, ananth@in.ibm.com Subject: Re: [PATCHv2 2/8] perf probe: Improve detection of file/function name in the probe pattern Message-ID: <20150427050517.GA6113@naverao1-tp.in.ibm.com> References: <20150312202414.GD3550@kernel.org> <5502C7EF.8080007@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5502C7EF.8080007@hitachi.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15042705-0033-0000-0000-0000056BE5CE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/03/13 08:20PM, Masami Hiramatsu wrote: > (2015/03/13 5:24), Arnaldo Carvalho de Melo wrote: > > Em Mon, Dec 15, 2014 at 08:20:32PM +0530, Naveen N. Rao escreveu: > >> Currently, perf probe considers patterns including a '.' to be a file. > >> However, this causes problems on powerpc ABIv1 where all functions have > >> a leading '.': > >> > >> $ perf probe -F | grep schedule_timeout_interruptible > >> .schedule_timeout_interruptible > >> $ perf probe .schedule_timeout_interruptible > >> Semantic error :File always requires line number or lazy pattern. > >> Error: Command Parse Error. > >> > >> Fix this by checking the probe pattern in more detail. > > > > Masami, can I have your Acked-by or Reviewed-by? > > As far as I can see, this is not enough for fixing that issue. > Could you fold the first half of [4/8] to this patch? Sure. > I also have some comments on it. See below. > > > > >> Signed-off-by: Naveen N. Rao > >> --- > >> tools/perf/util/probe-event.c | 23 ++++++++++++++++++++--- > >> 1 file changed, 20 insertions(+), 3 deletions(-) > >> > >> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > >> index 28eb141..9943ff3 100644 > >> --- a/tools/perf/util/probe-event.c > >> +++ b/tools/perf/util/probe-event.c > >> @@ -999,6 +999,24 @@ static int parse_perf_probe_point(char *arg, struct perf_probe_event *pev) > >> arg = tmp; > >> } > >> > >> + /* > >> + * Check arg is function or file name and copy it. > >> + * > >> + * We consider arg to be a file spec if and only if it satisfies > >> + * all of the below criteria:: > >> + * - it does not include any of "+@%", > >> + * - it includes one of ":;", and > >> + * - it has a period '.' in the name. > >> + * > >> + * Otherwise, we consider arg to be a function specification. > >> + */ > >> + c = 0; > > Oh please, don't reuse 'char c' for a boolean flag, you should > introduce new 'bool file_loc' etc. > > >> + if (!strpbrk(arg, "+@%") && (ptr = strpbrk(arg, ";:")) != NULL) { > >> + /* This is a file spec if it includes a '.' before ; or : */ > >> + if (memchr(arg, '.', ptr-arg)) > ^^ add spaces around '-'. Sure. - Naveen