From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753027AbbD0NEk (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Apr 2015 09:04:40 -0400
Received: from verein.lst.de ([213.95.11.211]:36013 "EHLO newverein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751952AbbD0NEh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Apr 2015 09:04:37 -0400
Date: Mon, 27 Apr 2015 15:04:36 +0200
From: Christoph Hellwig <hch@lst.de>
To: NeilBrown <neilb@suse.de>
Cc: Jens Axboe <axboe@fb.com>, Tejun Heo <tj@kernel.org>,
        Christoph Hellwig <hch@lst.de>, lkml <linux-kernel@vger.kernel.org>,
        viro@zeniv.linux.org.uk
Subject: Re: [PATCH] block: turn Oops into WARNING if bdi_register_dev
	fails.
Message-ID: <20150427130436.GB31842@lst.de>
References: <20150427151931.7a43ecc6@notabene.brown>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150427151931.7a43ecc6@notabene.brown>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 27, 2015 at 03:19:31PM +1000, NeilBrown wrote:
> 
> add_disk() does not return an error status, but it can
> still fail if there are problems elsewhere.
> 
> In particular a recent problem caused bdi_register_dev()
> to sometimes fail because the name was already in use.

I guess that's the best workaround for now, but we'll really need to tackle
the problem that add_disk can return errors proper eventually.