From: Mark Brown <broonie@kernel.org>
To: Michael Welling <mwelling@ieee.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: omap2-mcspi: Add support for GPIO chipselects
Date: Mon, 27 Apr 2015 20:55:50 +0100 [thread overview]
Message-ID: <20150427195550.GE22845@sirena.org.uk> (raw)
In-Reply-To: <1430106270-17142-1-git-send-email-mwelling@ieee.org>
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
On Sun, Apr 26, 2015 at 10:44:30PM -0500, Michael Welling wrote:
> + if (gpio_is_valid(spi->cs_gpio)) {
> + gpio_set_value(spi->cs_gpio, (cs_active) ?
> + !!(spi->mode & SPI_CS_HIGH) :
> + !(spi->mode & SPI_CS_HIGH));
> + }
Two problems here. One is that the above logic statement is just not
readable (the repitition of hecks, the ternery operator, the
indentation...) and the other is that the core chipselect support
already handles GPIO chipselects so you should really be converting the
driver to use that. At the very least the code needs to be legible
though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-27 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 3:44 Michael Welling
2015-04-27 19:55 ` Mark Brown [this message]
2015-04-28 1:21 ` Michael Welling
2015-04-28 5:32 ` Martin Sperl
2015-04-28 22:49 ` Michael Welling
2015-04-28 14:04 ` Ezequiel Garcia
2015-04-28 22:50 ` Michael Welling
2015-04-28 14:34 ` Mark Brown
2015-04-28 23:06 ` Michael Welling
2015-04-29 10:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427195550.GE22845@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome