From: Andrew Morton <akpm@linux-foundation.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@odin.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
target-devel@vger.kernel.org
Subject: Re: [PATCH] scatterlist: enable sg chaining for all architectures
Date: Tue, 28 Apr 2015 14:27:43 -0700 [thread overview]
Message-ID: <20150428142743.578d1c930aca013b596d7546@linux-foundation.org> (raw)
In-Reply-To: <1429973776-7499-1-git-send-email-akinobu.mita@gmail.com>
On Sat, 25 Apr 2015 23:56:16 +0900 Akinobu Mita <akinobu.mita@gmail.com> wrote:
> Some architectures enable sg chaining option while others do not.
>
> The requirement to enable sg chaining is that pages must be aligned
> at a 32-bit boundary in order to overload the LSB of the pointer.
> Regardless of whether ARCH_HAS_SG_CHAIN is defined or not, the above
> requirement is always chacked by BUG_ON() in sg_assign_page. So
> all architectures can enable sg chaining.
>
> As you can see from the changes in drivers/target/target_core_rd.c,
> enabling SG chaining for all architectures allows us to allocate
> discontiguous scatterlist tables which can be traversed throughout
> by sg_next() without a special handling for some architectures.
Thanks, I'll grab this. If anyone has concerns, speak now or hold both
pieces!
next prev parent reply other threads:[~2015-04-28 21:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 14:56 Akinobu Mita
2015-04-28 21:27 ` Andrew Morton [this message]
2015-04-28 22:16 ` James Bottomley
2015-04-29 0:34 ` Akinobu Mita
2015-04-29 2:15 ` James Bottomley
2015-04-29 7:31 ` Boaz Harrosh
2015-04-30 7:59 ` Nicholas A. Bellinger
2015-04-30 14:55 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428142743.578d1c930aca013b596d7546@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=JBottomley@odin.com \
--cc=akinobu.mita@gmail.com \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®