From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031149AbbD1WOX (ORCPT ); Tue, 28 Apr 2015 18:14:23 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35016 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030444AbbD1WOW (ORCPT ); Tue, 28 Apr 2015 18:14:22 -0400 Date: Tue, 28 Apr 2015 15:14:20 -0700 From: Andrew Morton To: "Kirill A. Shutemov" Cc: Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] compaction: fix isolate_migratepages_block() for THP=n Message-Id: <20150428151420.227e7ac34745e9fe8e9bc145@linux-foundation.org> In-Reply-To: <1430134006-215317-1-git-send-email-kirill.shutemov@linux.intel.com> References: <1430134006-215317-1-git-send-email-kirill.shutemov@linux.intel.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Apr 2015 14:26:46 +0300 "Kirill A. Shutemov" wrote: > PageTrans* helpers are always-false if THP is disabled compile-time. > It means the fucntion will fail to detect hugetlb pages in this case. > > Let's use PageCompound() instead. With small tweak to how we calculate > next low_pfn it will make function ready to see tail pages. So this patch has no runtime effects at present? It is preparation for something else?