From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030676AbbD1RYd (ORCPT ); Tue, 28 Apr 2015 13:24:33 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:38127 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030328AbbD1RYa (ORCPT ); Tue, 28 Apr 2015 13:24:30 -0400 Date: Tue, 28 Apr 2015 12:22:51 -0500 From: Felipe Balbi To: Heikki Krogerus CC: Felipe Balbi , David Cohen , Greg Kroah-Hartman , Stephen Boyd , Baolu Lu , Paul Bolle , , Subject: Re: [PATCHv3 06/11] usb: dwc3: soft reset to it's own function Message-ID: <20150428172251.GO18263@saruman.tx.rr.com> Reply-To: References: <1430227486-225197-1-git-send-email-heikki.krogerus@linux.intel.com> <1430227486-225197-7-git-send-email-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wqJr86X7F8PBspU2" Content-Disposition: inline In-Reply-To: <1430227486-225197-7-git-send-email-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wqJr86X7F8PBspU2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 28, 2015 at 04:24:41PM +0300, Heikki Krogerus wrote: > So it can be called from other places later. >=20 > Signed-off-by: Heikki Krogerus > Acked-by: David Cohen > --- > drivers/usb/dwc3/core.c | 46 ++++++++++++++++++++++++++++++-------------= --- > 1 file changed, 30 insertions(+), 16 deletions(-) >=20 > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 104b236..921f181 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -117,6 +117,33 @@ static int dwc3_core_soft_reset(struct dwc3 *dwc) > } > =20 > /** > + * dwc3_soft_reset - Issue soft reset > + * @dwc: Pointer to our controller context structure > + */ > +static int dwc3_soft_reset(struct dwc3 *dwc) I don't see this being called anywhere else in your series and I would really like to know when we would need to reset the core again ? I don't oppose to having this split to own function because I rather like how it looks, but I don't want to reset the IP needlessly either. cheers --=20 balbi --wqJr86X7F8PBspU2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVP8HrAAoJEIaOsuA1yqREn2MQAJKEYD98wxh9p5h8Lln9+dGj n7jEkogjiCxeATA61cV1cNaMW94vIjchXuUBEn+k8yKR70kSRKu5Jgip+pP2FdLq pplSXFF+mI7FzSuVnUk2UNvC5Wsk4zDk/RJMNL55m3yik40RDFHitiKbGffeIAwd 1BHGlO5VGRKPubhI69LHXhd1xv8gJf2eu+RTPWFmnCNls3j3YAomHoko62lC7jPG J5sTwd84qDA7idAFdA/q4OGB98yEIsVeNjAeyj2PPGRq2vuyo/NYq0/OciR5oGrX 1V2D8ULVHRgC9+SWp3AzXMDcXhdf303kTMSZgcUFDOZRvwQk5wGAW0sJWu+H7nFq UyjrIeyfNTQyDvbcROeY1P7j4TYUq78fq1msIpvqrhO5BrPPnlRH02y62txTnT7f ORnP/X8RdbuLG7WQTLYmQmOuOCuj5ArkSad4huTWXTtfMtnouz1R0HlPkgmlUtfC C1NuzvLrZVEqNEXxwR0wvNrdDcCkhVBEu9kvD5Q9eWojymjTXqAhJjuGZeFohuA6 c694h5KEmvMJM8hG6sJP4aQuDBzVvP7n4K4lHlaMHRFQVc1hOrANcg1QRllUJZkt ++dc0sdQD9sH9jTyK661Slpvzic/az0uRGApF2ftf87FnDDOy/R/DMB01/GILwxW dCUzZF9C/A2YVSm2lx9s =2Bsw -----END PGP SIGNATURE----- --wqJr86X7F8PBspU2--