From: David Miller <davem@davemloft.net>
To: kys@microsoft.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
jasowang@redhat.com
Subject: Re: [PATCH V2 net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()
Date: Wed, 29 Apr 2015 15:21:26 -0400 (EDT) [thread overview]
Message-ID: <20150429.152126.847523297244536648.davem@davemloft.net> (raw)
In-Reply-To: <1430269188-31701-1-git-send-email-kys@microsoft.com>
From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: Tue, 28 Apr 2015 17:59:48 -0700
> Commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory
> allocation in the packet send path:
>
> "hv_netvsc: Eliminate memory allocation in the packet send path
>
> The network protocol used to communicate with the host is the remote ndis (rndis)
> protocol. We need to decorate each outgoing packet with a rndis header and
> additional rndis state (rndis per-packet state). To manage this state, we
> currently allocate memory in the transmit path. Eliminate this allocation by
> requesting additional head room in the skb."
>
> This commit introduced a bug since it did not account for the case if the skb
> was cloned. Fix this bug.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Applied, thanks.
prev parent reply other threads:[~2015-04-29 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 0:59 K. Y. Srinivasan
2015-04-29 3:51 ` Dexuan Cui
2015-04-29 19:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429.152126.847523297244536648.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®