From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031677AbbD2IQa (ORCPT ); Wed, 29 Apr 2015 04:16:30 -0400 Received: from mga01.intel.com ([192.55.52.88]:7201 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031044AbbD2IQZ (ORCPT ); Wed, 29 Apr 2015 04:16:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,669,1422950400"; d="scan'208";a="702570701" Date: Wed, 29 Apr 2015 11:16:21 +0300 From: Heikki Krogerus To: Felipe Balbi Cc: David Cohen , Greg Kroah-Hartman , Stephen Boyd , Baolu Lu , Paul Bolle , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 06/11] usb: dwc3: soft reset to it's own function Message-ID: <20150429081621.GB25288@kuha.fi.intel.com> References: <1430227486-225197-1-git-send-email-heikki.krogerus@linux.intel.com> <1430227486-225197-7-git-send-email-heikki.krogerus@linux.intel.com> <20150428172251.GO18263@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150428172251.GO18263@saruman.tx.rr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + * dwc3_soft_reset - Issue soft reset > > + * @dwc: Pointer to our controller context structure > > + */ > > +static int dwc3_soft_reset(struct dwc3 *dwc) > > I don't see this being called anywhere else in your series and I would > really like to know when we would need to reset the core again ? > > I don't oppose to having this split to own function because I rather > like how it looks, but I don't want to reset the IP needlessly either. This series seems to be missing the last patch for dwc3, where I actually add the ULPI support to dwc3 :-p. How have I managed to prepare this series with one patch from the middle missing?!?! The cover letter seems to be correct. I'll resend the patches 8-12/12. Thanks, -- heikki