From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422782AbbD2J0R (ORCPT ); Wed, 29 Apr 2015 05:26:17 -0400 Received: from mga09.intel.com ([134.134.136.24]:43790 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031643AbbD2J0O (ORCPT ); Wed, 29 Apr 2015 05:26:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,670,1422950400"; d="scan'208";a="487092442" Date: Wed, 29 Apr 2015 12:26:09 +0300 From: Mika Westerberg To: sathyanarayanan kuppuswamy Cc: "Rafael J. Wysocki" , Linus Walleij , Alexandre Courbot , Wolfram Sang , Octavian Purdila , Robert Dolca , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 0/2] ACPI: Translate Linux IRQ number directly from GpioInt Message-ID: <20150429092609.GP1534@lahna.fi.intel.com> References: <1430233507-29389-1-git-send-email-mika.westerberg@linux.intel.com> <553FC530.1020305@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <553FC530.1020305@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2015 at 10:36:48AM -0700, sathyanarayanan kuppuswamy wrote: > >This requires that the boot firmware (BIOS/coreboot) configures these pins > >correctly (input, etc) before handing over to OS. I've tested this on Intel > >Baytrail, Braswell and Skylake based machines where this is true. > > Why not configure the GPIO pin as input in the API itself ? IIRC Octavian tried to do just that but it turned out that some of the irqchip functions are called with spinlock held, which means you can't call all gpiod_* functions there (as they might sleep).