From: Herbert Xu <herbert@gondor.apana.org.au>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, Tawfik Bayouk <tawfik@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Thomas Petazzoni <info@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org>
Subject: Re: [PATCH 0/2] crypto: add new driver for Marvell CESA
Date: Wed, 29 Apr 2015 17:49:02 +0800 [thread overview]
Message-ID: <20150429094902.GC9874@gondor.apana.org.au> (raw)
In-Reply-To: <20150428215232.6834906c@bbrezillon>
On Tue, Apr 28, 2015 at 09:52:32PM +0200, Boris Brezillon wrote:
>
> In particular, I'd like to discuss the threaded-irq approach taken in
> this driver (other drivers are using tasklets).
> The main reason behind this choice is the fact that crypto engines
> are quite fast, and I'm worried about the CPU contention that might
> happen in case of fully loaded crypto engines (the CPU might spend most
> of its time in interrupt context until the crypto queue is emptied).
> Using threaded-irq allows preemption of the crypto completion
> operation, thus authorizing another thread (with higher priority) to be
> scheduled. ITOH, the tasklet approach provide slightly performances (I
> don't recall the exact numbers, but Arnaud did some tests).
Either approach is fine with me.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2015-04-29 9:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 14:58 Boris Brezillon
2015-04-09 14:58 ` [PATCH 1/2] " Boris Brezillon
2015-04-10 10:38 ` Paul Bolle
2015-04-10 11:17 ` Boris Brezillon
2015-04-09 14:58 ` [PATCH 2/2] crypto: marvell/CESA: update DT bindings documentation Boris Brezillon
2015-04-09 15:18 ` [PATCH 0/2] crypto: add new driver for Marvell CESA Andrew Lunn
[not found] ` <20150409172826.18916274@bbrezillon>
2015-04-09 15:37 ` Andrew Lunn
2015-04-09 15:34 ` Sebastian Hesselbarth
2015-04-09 15:57 ` Boris Brezillon
2015-04-09 23:21 ` Arnaud Ebalard
2015-04-09 15:52 ` Stephan Mueller
2015-04-10 13:50 ` Jason Cooper
2015-04-10 15:11 ` Boris Brezillon
2015-04-10 22:30 ` Jason Cooper
2015-04-13 9:39 ` Gregory CLEMENT
2015-04-13 12:47 ` Jason Cooper
2015-04-13 16:06 ` Arnaud Ebalard
2015-04-13 20:11 ` Jason Cooper
2015-04-17 8:33 ` Boris Brezillon
2015-04-17 8:39 ` Boris Brezillon
2015-04-17 10:59 ` Jason Cooper
2015-04-17 13:01 ` Gregory CLEMENT
2015-04-17 14:19 ` Boris Brezillon
2015-04-17 14:32 ` Maxime Ripard
2015-04-17 14:40 ` Gregory CLEMENT
2015-04-17 14:50 ` Maxime Ripard
2015-04-17 15:01 ` Gregory CLEMENT
2015-04-17 15:49 ` Maxime Ripard
2015-04-17 16:04 ` Gregory CLEMENT
2015-04-28 19:52 ` Boris Brezillon
2015-04-29 9:49 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429094902.GC9874@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=benavi@marvell.com \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=info@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®