From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423312AbbD2PFM (ORCPT ); Wed, 29 Apr 2015 11:05:12 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:56269 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423009AbbD2PFH (ORCPT ); Wed, 29 Apr 2015 11:05:07 -0400 Date: Wed, 29 Apr 2015 10:03:32 -0500 From: Felipe Balbi To: Heikki Krogerus CC: Felipe Balbi , David Cohen , Greg Kroah-Hartman , Stephen Boyd , Baolu Lu , Paul Bolle , , Subject: Re: [PATCHv3 08/12] usb: dwc3: add hsphy_interface property Message-ID: <20150429150332.GB7262@saruman.tx.rr.com> Reply-To: References: <20150429082113.GC25288@kuha.fi.intel.com> <1430296233-144245-1-git-send-email-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zx4FCpZtqtKETZ7O" Content-Disposition: inline In-Reply-To: <1430296233-144245-1-git-send-email-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zx4FCpZtqtKETZ7O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 29, 2015 at 11:30:29AM +0300, Heikki Krogerus wrote: > Platforms that have configured DWC_USB3_HSPHY_INTERFACE with > value 3, i.e. UTMI+ and ULPI, need to inform the driver of > the actual HSPHY interface type with the property. "utmi" if > the interface is UTMI+ or "ulpi" if the interface is ULPI. >=20 > Signed-off-by: Heikki Krogerus > Acked-by: David Cohen > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ > drivers/usb/dwc3/core.c | 29 ++++++++++++++++++++= ++++-- > drivers/usb/dwc3/core.h | 3 +++ > drivers/usb/dwc3/platform_data.h | 2 ++ > 4 files changed, 34 insertions(+), 2 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentati= on/devicetree/bindings/usb/dwc3.txt > index 5cc3643..0815eac 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -38,6 +38,8 @@ Optional properties: > - snps,is-utmi-l1-suspend: true when DWC3 asserts output signal > utmi_l1_suspend_n, false when asserts utmi_sleep_n > - snps,hird-threshold: HIRD threshold > + - snps,hsphy_interface: High-Speed PHY interface selection between "utm= i" for > + UTMI+ and "ulpi" for ULPI when the DWC_USB3_HSPHY_INTERFACE has value= 3. > =20 > This is usually a subnode to DWC3 glue to which it is connected. > =20 > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 6b02e12..fdeff5e 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -395,9 +395,10 @@ static void dwc3_cache_hwparams(struct dwc3 *dwc) > * dwc3_phy_setup - Configure USB PHY Interface of DWC3 Core > * @dwc: Pointer to our controller context structure > */ > -static void dwc3_phy_setup(struct dwc3 *dwc) > +static int dwc3_phy_setup(struct dwc3 *dwc) > { > u32 reg; > + int ret; unused variable --=20 balbi --zx4FCpZtqtKETZ7O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVQPLEAAoJEIaOsuA1yqRE9UgP/2fU8MGs8tCoBs7qojzC8hdK i4oQC9umZ1cAryFD3vMgUB6tTawud2FTi0/3jnV8+ZN9QHEHxx13/u5gVVxYTvgx zteprbWWX0b3b4/VBAsmlecXwdyTQtVvFISxdTnPoVo8h9mgFzbsq+V1cuY+k83M blweYyidJVVqZ//6S2SSlwsm7tHNcxZt3rZT5n3+l8SH1MOXIaYL4wxTtd+quJRB pXFWgGNFOY/wIO9oYUWwBx9wwTBA+hAyT0hwrUzFyjtFram3LdRDv1N/DOiTS1zM mfCtPDY9al5RXYUQCJOO9evxHwiBFVDH8D67IkQcBXr7JaaaEm92C7l9QHLjCH5x I0DnQZR/5O+3LHOS3v8tkQQGQsK0z4R4bLe6iJcOWbHqo9ePuIrROL10+MZuCE8C OkB/JKheT2W2JY2gCDTYAbqQezvDT9B6YFIbG23V2h8Dehg2mjyZtPUuSTtkTEOt AsPgL2XmUTIOq66n7jwwF43493rAh/d2m/v1xYImOGFuRuY4YtF2WS+PcmauuLCo LuovAyLjG1Oxcde8PD76xOMwNE5jkNU//C9wWjI+WR573TIOUkWVrJIlpY5ohuRg n8gRkxufflatNcCE8q0a3yTKBMquek4FuKiV13/J1NVZv7kCAjiUV4l18K/4rjco nVb58Xy2EbeB8vSgTP1v =GKb7 -----END PGP SIGNATURE----- --zx4FCpZtqtKETZ7O--