mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Borislav Petkov <bp@alien8.de>
Cc: Daniel J Blueman <daniel@numascale.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Quentin Casasnovas <quentin.casasnovas@oracle.com>,
	Steffen Persvold <sp@numascale.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] x86: Unbreak early processor microcode loading
Date: Wed, 29 Apr 2015 15:23:57 -0300	[thread overview]
Message-ID: <20150429182357.GB14218@khazad-dum.debian.net> (raw)
In-Reply-To: <20150319092703.GA10860@pd.tnic>

On Thu, 19 Mar 2015, Borislav Petkov wrote:
> On Thu, Mar 19, 2015 at 03:30:23PM +0800, Daniel J Blueman wrote:
> > Neat; I added the 'amd-ucode/' directory prefix to the string and adjusted
> > the buffer size, and the microcode is loaded,
> 
> We shouldn't need to do that though for obvious reasons.
> 
> IOW, you need to type in only the filenames of the microcode blobs in Kconfig
> option:
> 
> CONFIG_EXTRA_FIRMWARE="microcode_amd.bin microcode_amd_fam15h.bin microcode_amd_fam16h.bin"
> 
> and then add the absolute path to them with:
> 
> CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware/amd-ucode"
> 
> That worked here yesterday.

I apologise for the late reply.  Please disregard it if it is outdated.

That would obviously work, but people often have other firmware
built-in, so the likehood of CONFIG_EXTRA_FIRMWARE_DIR pointing to the
root of a linux-firmware work tree or to "/lib/firmware" is not low at
all.

In fact, it is natural to expect that CONFIG_EXTRA_FIRMWARE should point
to something that will result in the same filenames as the kernel would
want to use for regular firmware loading.  The current text of the
Kconfig help for CONFIG_EXTRA_FIRMWARE even says so.

So, FWIW, I do think we should always use the same path for builtin and
regular firmware requests, based on the least-surprise principle.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2015-04-29 18:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 15:10 Daniel J Blueman
2015-03-03 16:38 ` Borislav Petkov
2015-03-04  8:27   ` Daniel J Blueman
2015-03-04  9:18     ` Borislav Petkov
2015-03-04 11:45       ` Borislav Petkov
2015-03-18  9:09         ` Daniel J Blueman
2015-03-18 10:02           ` Borislav Petkov
2015-03-18 18:42             ` Borislav Petkov
2015-03-19  7:30               ` Daniel J Blueman
2015-03-19  9:27                 ` Borislav Petkov
2015-04-29 18:23                   ` Henrique de Moraes Holschuh [this message]
2015-04-29 18:43                     ` Borislav Petkov
2015-04-29 20:54                       ` Henrique de Moraes Holschuh
2015-04-29 21:45                         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150429182357.GB14218@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=bp@alien8.de \
    --cc=daniel@numascale.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=quentin.casasnovas@oracle.com \
    --cc=sp@numascale.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®