From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbbD3KyI (ORCPT ); Thu, 30 Apr 2015 06:54:08 -0400 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:33904 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbbD3KyF (ORCPT ); Thu, 30 Apr 2015 06:54:05 -0400 Date: Thu, 30 Apr 2015 11:53:45 +0100 From: One Thousand Gnomes To: Trevor Cordes Cc: linux-kernel@vger.kernel.org, John Stultz , Thomas Gleixner , Josh Boyer Subject: Re: regression in ktime.h circa 3.16.0-rc5+ breaks lirc irsend, bad commit 166afb64511 Message-ID: <20150430115345.1204406e@lxorguk.ukuu.org.uk> In-Reply-To: <20150429232721.59b89cb1@pog.tecnopolis.ca> References: <20150323165725.GA25008@pog.tecnopolis.ca> <20150429232721.59b89cb1@pog.tecnopolis.ca> Organization: Intel Corporation X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Obviously my patch isn't the real solution, the real solution is to > > make the new function calls use a consistent 64-bit type, or figure > > out what in my code path is calling these functions and check it for > > value sanity. I would be tempted to do both computations and print then inputs as well as do a WARN_ON when they differ. That will give you a stack trace of the offender, and providing you return the "correct" value you can see how it continues functioning afterwards. Alan