From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbbD3QWY (ORCPT ); Thu, 30 Apr 2015 12:22:24 -0400 Received: from mta-out1.inet.fi ([62.71.2.203]:59053 "EHLO kirsi1.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbbD3QWG (ORCPT ); Thu, 30 Apr 2015 12:22:06 -0400 Date: Thu, 30 Apr 2015 19:22:01 +0300 From: "Kirill A. Shutemov" To: Sasha Levin Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [RFC 07/11] mm: debug: VM_BUG() Message-ID: <20150430162201.GC17344@node.dhcp.inet.fi> References: <1429044993-1677-1-git-send-email-sasha.levin@oracle.com> <1429044993-1677-8-git-send-email-sasha.levin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429044993-1677-8-git-send-email-sasha.levin@oracle.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2015 at 04:56:29PM -0400, Sasha Levin wrote: > VM_BUG() complements VM_BUG_ON() just like with WARN() and WARN_ON(). > > This lets us format custom strings to output when a VM_BUG() is hit. > > Signed-off-by: Sasha Levin > --- > include/linux/mmdebug.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h > index 8b3f5a0..42f41e3 100644 > --- a/include/linux/mmdebug.h > +++ b/include/linux/mmdebug.h > @@ -12,7 +12,14 @@ char *format_page(struct page *page, char *buf, char *end); > #ifdef CONFIG_DEBUG_VM > char *format_vma(const struct vm_area_struct *vma, char *buf, char *end); > char *format_mm(const struct mm_struct *mm, char *buf, char *end); > -#define VM_BUG_ON(cond) BUG_ON(cond) > +#define VM_BUG(cond, fmt...) \ vm_bugf() ? ;) -- Kirill A. Shutemov