From: Mark Brown <broonie@kernel.org>
To: Martin Fuzzey <mfuzzey@parkeon.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] Regulator: mc34708: Add DT binding documentation
Date: Thu, 30 Apr 2015 19:56:57 +0100 [thread overview]
Message-ID: <20150430185657.GB22845@sirena.org.uk> (raw)
In-Reply-To: <20150428141738.16243.18377.stgit@localhost>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Tue, Apr 28, 2015 at 04:17:38PM +0200, Martin Fuzzey wrote:
> + pmic_sw3_reg: sw3 {
> + regulator-name = "SW3";
> + regulator-min-microvolt = <650000>;
> + regulator-max-microvolt = <1425000>;
> + };
These examples look awfully like you're just listiong the maximum range
allowed by the PMIC for all the supplies which is almost never something
someone would want to do on a real board. Similarly all the names are
just the name of the regulator rather than something that looks like a
board specific name.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-30 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 14:17 [PATCH 0/2] regulator: Add regulator driver for the MC34708 PMIC Martin Fuzzey
2015-04-28 14:17 ` [PATCH 1/2] Regulator: mc34708: Add DT binding documentation Martin Fuzzey
2015-04-30 18:56 ` Mark Brown [this message]
2015-05-01 10:34 ` Stefan Wahren
2015-05-01 11:01 ` Mark Brown
2015-05-01 12:33 ` Stefan Wahren
2015-05-01 14:03 ` Mark Brown
2015-05-11 9:36 ` Javier Martinez Canillas
2015-04-28 14:17 ` [PATCH 2/2] Regulator: add driver for Freescale MC34708 Martin Fuzzey
2015-04-29 8:42 ` Paul Bolle
2015-04-30 19:45 ` Mark Brown
2015-05-11 9:04 ` Martin Fuzzey
2015-05-11 14:09 ` Mark Brown
2015-05-01 10:38 ` Stefan Wahren
2015-05-01 10:26 ` [PATCH 0/2] regulator: Add regulator driver for the MC34708 PMIC Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430185657.GB22845@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfuzzey@parkeon.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®