From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753533AbbEAKKY (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 May 2015 06:10:24 -0400
Received: from casper.infradead.org ([85.118.1.10]:45468 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750904AbbEAKKX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 May 2015 06:10:23 -0400
Date: Fri, 1 May 2015 12:10:07 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ben Segall <bsegall@google.com>,
        LKP <lkp@01.org>, linux-kernel@vger.kernel.org
Subject: Re: [sched] WARNING: CPU: 0 PID: 0 at kernel/time/hrtimer.c:802
 hrtimer_forward()
Message-ID: <20150501101007.GB5029@twins.programming.kicks-ass.net>
References: <20150501044713.GA4365@wfg-t540p.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150501044713.GA4365@wfg-t540p.sh.intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 01, 2015 at 12:47:13PM +0800, Fengguang Wu wrote:
> commit 77a4d1a1b9a122ca1fa3507bd30aec1520d7a8a4
>     sched: Cleanup bandwidth timers

> [   64.000438] WARNING: CPU: 0 PID: 0 at kernel/time/hrtimer.c:802 hrtimer_forward+0x71/0x189()

Argh, yes of course. The problem is that the timer can be re-started
before the handler acquires the lock, and therefore the hrtimer_forwards
in the handler will trigger that WARN.

Lemme try and go convince this heap of snot that's occupying my brain
cavity to produce coherent thought and come up with a nice fix for that.