From: Christoph Hellwig <hch@lst.de>
To: Shaohua Li <shli@fb.com>
Cc: linux-kernel@vger.kernel.org, axboe@fb.com, jmoyer@redhat.com,
hch@lst.de, neilb@suse.de
Subject: Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out
Date: Fri, 1 May 2015 19:14:10 +0200 [thread overview]
Message-ID: <20150501171410.GB16920@lst.de> (raw)
In-Reply-To: <9eedafbfb33bf3e8d273860e75f9f07ca9b0d5ec.1430414610.git.shli@fb.com>
On Thu, Apr 30, 2015 at 10:45:15AM -0700, Shaohua Li wrote:
> long __sched io_schedule_timeout(long timeout)
> {
> - int old_iowait = current->in_iowait;
> struct rq *rq;
> long ret;
>
> current->in_iowait = 1;
> - if (old_iowait)
> - blk_schedule_flush_plug(current);
> - else
> - blk_flush_plug(current);
> + blk_schedule_flush_plug(current);
>
> delayacct_blkio_start();
> rq = raw_rq();
> atomic_inc(&rq->nr_iowait);
> ret = schedule_timeout(timeout);
> - current->in_iowait = old_iowait;
> + current->in_iowait = 0;
Always clearing ->in_iowait is behavior change not mentioned in the
changelog. Even if it was intentional it would better be done in
a separate patch.
next prev parent reply other threads:[~2015-05-01 17:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 17:45 [PATCH 0/5] blk plug fixes Shaohua Li
2015-04-30 17:45 ` [PATCH 1/5] blk: clean up plug Shaohua Li
2015-05-01 17:11 ` Christoph Hellwig
2015-04-30 17:45 ` [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out Shaohua Li
2015-05-01 17:14 ` Christoph Hellwig [this message]
2015-05-01 18:05 ` Shaohua Li
2015-05-01 17:42 ` Jeff Moyer
2015-05-01 18:07 ` Jeff Moyer
2015-05-01 18:28 ` Shaohua Li
2015-05-01 19:37 ` Jeff Moyer
2015-04-30 17:45 ` [PATCH 3/5] blk-mq: fix plugging in blk_sq_make_request Shaohua Li
2015-05-01 17:16 ` Christoph Hellwig
2015-05-01 17:47 ` Jeff Moyer
2015-04-30 17:45 ` [PATCH 4/5] blk-mq: do limited block plug for multiple queue case Shaohua Li
2015-05-01 20:16 ` Jeff Moyer
2015-05-04 19:40 ` Shaohua Li
2015-05-04 19:46 ` Jens Axboe
2015-05-04 20:33 ` Shaohua Li
2015-05-04 20:35 ` Jens Axboe
2015-04-30 17:45 ` [PATCH 5/5] blk-mq: make plug work for mutiple disks and queues Shaohua Li
2015-05-01 20:55 ` Jeff Moyer
2015-05-04 19:44 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501171410.GB16920@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®