From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751922AbbEBSfR (ORCPT ); Sat, 2 May 2015 14:35:17 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:44889 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751273AbbEBSfP (ORCPT ); Sat, 2 May 2015 14:35:15 -0400 Date: Sat, 2 May 2015 20:35:04 +0200 From: Peter Zijlstra To: Vikas Shivappa Cc: vikas.shivappa@intel.com, linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, matt.fleming@intel.com, will.auld@intel.com, peter.zijlstra@intel.com, h.peter.anvin@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 1/7] x86/intel_rdt: Intel Cache Allocation Technology detection Message-ID: <20150502183504.GF3007@worktop.Skamania.guest> References: <1430530601-16319-1-git-send-email-vikas.shivappa@linux.intel.com> <1430530601-16319-2-git-send-email-vikas.shivappa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430530601-16319-2-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2015 at 06:36:35PM -0700, Vikas Shivappa wrote: > +#define X86_FEATURE_RDT ( 9*32+15) /* Resource Allocation */ > +#define X86_FEATURE_CAT_L3 (13*32 + 1) /* Cache QOS Enforcement L3 */ > + /* Cache Allocation Technology values */ > + u16 x86_cat_cbmlength; > + u16 x86_cat_closs; At the very least be consistent with the silly TLA nonsense.