From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbbECLHp (ORCPT ); Sun, 3 May 2015 07:07:45 -0400 Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:44250 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbbECLHf (ORCPT ); Sun, 3 May 2015 07:07:35 -0400 Date: Sun, 3 May 2015 13:07:15 +0200 From: Florian Westphal To: Liu Hua Cc: davem@davemloft.net, kadlec@blackhole.kfki.hu, kaber@trash.net, pablo@netfilter.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, liusdu@126.com Subject: Re: [PATCH] netfilter: fix dependency issues between IPv6 defragmentation and ip6tables Message-ID: <20150503110715.GE22481@breakpoint.cc> References: <1430646618-7625-1-git-send-email-sdu.liu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430646618-7625-1-git-send-email-sdu.liu@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Liu Hua wrote: > commit f6318e558806c925029dc101f14874be9f9fa78f fix some related issue > when ip6tables is enabled. But when IP6_NF_IPTABLES is disabled and > NETFILTER_XT_TARGET_TPROXY is enabled. We will meet build failure with > "net/built-in.o: In function `tproxy_tg_init': > net/netfilter/xt_TPROXY.c:588: undefined reference to `nf_defrag_ipv6_enable' > " > So this patch change the Kconfig as ipv4 does. > --- a/net/netfilter/Kconfig > +++ b/net/netfilter/Kconfig > @@ -865,7 +865,7 @@ config NETFILTER_XT_TARGET_TPROXY > depends on (IPV6 || IPV6=n) > depends on IP_NF_MANGLE > select NF_DEFRAG_IPV4 > - select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES > + select NF_DEFRAG_IPV6 If IP6_NF_IPTABLES is not set, why would we have to pick up IPV6 defragmentation? Without ip6tables, TPROXY cannot be used for ipv6; in fact; xt_TPROXY should be built without ipv6 support in this case. My guess is that you have TPROXY=y but DEFRAG_IPV6=m, but that might warrant a better fix (xt_socket seems to have same issue).