From: Greg KH <gregkh@linuxfoundation.org>
To: Kai Katsumata <imperialroyalguard38@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fix code style in socklnd_proto.c
Date: Sun, 3 May 2015 20:29:33 +0200 [thread overview]
Message-ID: <20150503182933.GA7356@kroah.com> (raw)
In-Reply-To: <1428330093-81788-1-git-send-email-imperialroyalguard38@gmail.com>
On Mon, Apr 06, 2015 at 11:21:33PM +0900, Kai Katsumata wrote:
> fix coding style by ./scripts/checkpatch.pl.
> fix 80 charracters limit, space prohibited between function name and
> open parenthesis '('
> and braces {} are not necessary for single statement blocks.
That's two different things, so this should be two different patches.
Each patch should only do one logical thing.
>
> Before patch is html format. But this is plain text format.
> Before patch is From: line didn't match the Signed-off-by line. Align
> the these lines.
This paragraph doesn't need to be here, please put it below the --- line
so it doesn't show up in the changelog.
thanks,
greg k-h
prev parent reply other threads:[~2015-05-03 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 14:21 Kai Katsumata
2015-05-03 18:29 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150503182933.GA7356@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=imperialroyalguard38@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome