Re: [PATCH 1/2] toshiba_acpi: Remove bluetooth rfkill code

[Darren Hart <dvhart@infradead.org>]

On Mon, Apr 27, 2015 at 02:30:53PM -0600, Azael Avalos wrote:
> This patch removes all bluetooth rfkill related code residing in
> the toshiba_acpi driver.
> 
> Separate patches will add (and adapt) the code to toshiba_bluetooth
> (where it belongs).
> 
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>

Hi Azael,

With this applied the driver as build warnings:

...
  CC [M]  drivers/platform/x86/toshiba_acpi.o
drivers/platform/x86/toshiba_acpi.c: In function ‘toshiba_acpi_add’:
drivers/platform/x86/toshiba_acpi.c:2636:7: warning: unused variable ‘bt_present’ [-Wunused-variable]
  bool bt_present;
       ^
drivers/platform/x86/toshiba_acpi.c: At top level:
drivers/platform/x86/toshiba_acpi.c:358:12: warning: ‘hci_write2’ defined but not used [-Wunused-function]
 static u32 hci_write2(struct toshiba_acpi_dev *dev, u32 reg, u32 in1, u32 in2)

I presume these should be removed as well?

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center