From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbbEDLop (ORCPT ); Mon, 4 May 2015 07:44:45 -0400 Received: from mga14.intel.com ([192.55.52.115]:22973 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542AbbEDLog (ORCPT ); Mon, 4 May 2015 07:44:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,366,1427785200"; d="scan'208";a="565857188" Date: Mon, 4 May 2015 04:44:35 -0700 From: Andi Kleen To: Jiri Olsa Cc: Sukadev Bhattiprolu , mingo@redhat.com, Michael Ellerman , Arnaldo Carvalho de Melo , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 4/4] perf: Create aliases for PMU events Message-ID: <20150504114435.GQ13605@tassilo.jf.intel.com> References: <1430463941-26109-1-git-send-email-sukadev@linux.vnet.ibm.com> <1430463941-26109-5-git-send-email-sukadev@linux.vnet.ibm.com> <20150502153814.GA21242@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150502153814.GA21242@krava.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I personaly like having set of event files in JSON notation > rather than having them directly in C structure Yes, strings are better and JSON input is also better. I prototyped translating JSON into the proposed structures. I already had to add three new fields, and it wouldn't work for uncore. The string format is much more extensible. BTW as expected the binary sizes are gigantic (for 14 CPU types): % size all.o text data bss dec hex filename 662698 0 0 662698 a1caa all.o % gcc -E all.c | wc -l 55475 -Andi