From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbbEDObe (ORCPT ); Mon, 4 May 2015 10:31:34 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:56247 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbbEDOb0 (ORCPT ); Mon, 4 May 2015 10:31:26 -0400 Date: Mon, 4 May 2015 16:31:05 +0200 From: Sascha Hauer To: Yingjoe Chen Cc: Mark Rutland , Matthias Brugger , Thomas Gleixner , Arnd Bergmann , Olof Johansson , devicetree@vger.kernel.org, Lorenzo Pieralisi , Russell King , Jason Cooper , Pawel Moll , Ian Campbell , Catalin Marinas , Daniel Lezcano , linux-kernel@vger.kernel.org, Marc Carino , Rob Herring , linux-mediatek@lists.infradead.org, Sascha Hauer , srv_heupstream@mediatek.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/7] ARM: dts: mt8135: enable basic SMP bringup for mt8135 Message-ID: <20150504143105.GK4946@pengutronix.de> References: <1430466210-22963-1-git-send-email-yingjoe.chen@mediatek.com> <1430466210-22963-7-git-send-email-yingjoe.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430466210-22963-7-git-send-email-yingjoe.chen@mediatek.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 16:29:07 up 49 days, 2:21, 89 users, load average: 0.10, 0.10, 0.13 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2015 at 03:43:29PM +0800, Yingjoe Chen wrote: > Add arch timer node to enable arch-timer support. MT8135 firmware > doesn't correctly setup arch-timer frequency and CNTVOFF, add > properties to workaround this. > > This also set cpu enable-method to enable SMP. > > Signed-off-by: Yingjoe Chen > --- > arch/arm/boot/dts/mt8135.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi > index 612bd22..eb5e06f 100644 > --- a/arch/arm/boot/dts/mt8135.dtsi > +++ b/arch/arm/boot/dts/mt8135.dtsi > @@ -46,6 +46,7 @@ > cpus { > #address-cells = <1>; > #size-cells = <0>; > + enable-method = "mediatek,mt81xx-tz-smp"; > > cpu0: cpu@0 { > device_type = "cpu"; > @@ -103,6 +104,21 @@ > }; > }; > > + timer { > + compatible = "arm,armv7-timer"; > + interrupt-parent = <&gic>; > + interrupts = + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>; > + clock-frequency = <13000000>; > + arm,cpu-registers-not-fw-configured; > + }; This is the SoC dtsi file. What you say here is that all MT8135 present and future firmwares on all boards do this wrong. Shouldn't you fix the firmware instead? Shouldn't this property be board specific? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |