From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751971AbbEDQ1l (ORCPT ); Mon, 4 May 2015 12:27:41 -0400 Received: from muru.com ([72.249.23.125]:49013 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbbEDQ1e (ORCPT ); Mon, 4 May 2015 12:27:34 -0400 Date: Mon, 4 May 2015 09:27:32 -0700 From: Tony Lindgren To: Nishanth Menon Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Illia Smyrnov Subject: Re: [PATCH] bus: omap_l3_noc: Fix offset for DRA7 CLK1_HOST_CLK1_2 instance Message-ID: <20150504162731.GO24469@atomide.com> References: <1429224150-28712-1-git-send-email-nm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429224150-28712-1-git-send-email-nm@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nishanth Menon [150416 15:43]: > From: Illia Smyrnov > > The base address for DRA7 CLK1_HOST_CLK1_2 host instance is > 0x44800000, so correct offset is 0x800000. DRA7 TRM rev X(fewb 2015) > has updates for this information. > > With wrong offset these errors are not correctly cleared by the L3 > IRQ handler and cause an continuous interrupt scenario and system lockup. > > Signed-off-by: Illia Smyrnov > Signed-off-by: Nishanth Menon > --- > drivers/bus/omap_l3_noc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/omap_l3_noc.h b/drivers/bus/omap_l3_noc.h > index 95254585db86..a314d800f394 100644 > --- a/drivers/bus/omap_l3_noc.h > +++ b/drivers/bus/omap_l3_noc.h > @@ -274,7 +274,7 @@ static struct l3_flagmux_data dra_l3_flagmux_clk1 = { > > static struct l3_target_data dra_l3_target_data_clk2[] = { > {0x0, "HOST CLK1",}, > - {0x0, "HOST CLK2",}, > + {0x800000, "HOST CLK2",}, > {0xdead, L3_TARGET_NOT_SUPPORTED,}, > {0x3400, "SHA2_2",}, > {0x0900, "BB2D",}, Applying into omap-for-v4.1/fixes thanks. Tony