From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422885AbbEEMeu (ORCPT ); Tue, 5 May 2015 08:34:50 -0400 Received: from hofr.at ([212.69.189.236]:47431 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422851AbbEEMel (ORCPT ); Tue, 5 May 2015 08:34:41 -0400 Date: Tue, 5 May 2015 14:34:38 +0200 From: Nicholas Mc Guire To: Gleb Natapov Cc: Paolo Bonzini , Ralf Baechle , kvm@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: [BUG ?] MIPS: KVM: condition with no effect Message-ID: <20150505123438.GA21514@opentech.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi ! Not sure if this is a bug or maybe a placeholder for something... so patch - but maybe someone that knows this code can give it a look. arch/mips/kvm/emulate.c:emulation_result kvm_mips_complete_mmio_load() 2414 case 2: 2415 if (vcpu->mmio_needed == 2) 2416 *gpr = *(int16_t *) run->mmio.data; 2417 else 2418 *gpr = *(int16_t *) run->mmio.data; 2419 2420 break; either the if/else is not needed or one of the branches is wrong or it is a place-holder for somethign that did not get done - in which case a few lines explaining this would be nice (e.g. like in arch/sh/kernel/traps_64.c line 59) line numbers refer to 4.1-rc2 thx! hofrat