From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030226AbbEFDT2 (ORCPT ); Tue, 5 May 2015 23:19:28 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.227]:3789 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965610AbbEFDTW (ORCPT ); Tue, 5 May 2015 23:19:22 -0400 Date: Tue, 5 May 2015 23:19:32 -0400 From: Steven Rostedt To: Badhri Jagan Sridharan Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tracing: Adds handler name to irq_handler_entry Message-ID: <20150505231932.1500a4ad@grimm.local.home> In-Reply-To: <1430881587-13522-1-git-send-email-Badhri@google.com> References: <1430881587-13522-1-git-send-email-Badhri@google.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Added Thomas to the Cc, as he maintains interrupts ] On Tue, 5 May 2015 20:06:27 -0700 Badhri Jagan Sridharan wrote: > This patch includes the ISR function name to > irq_handler_entry trace point. It states what this patch does, but not why it does it. How much more difficult to map the handler to the interrupt? Just asking, I'm not sure I needed this, and I use this tracepoint all the time. But then again, I'm a bit of an tracing expert, and can add function graph tracing to see what is happening too. I shouldn't always be the judge on usefulness of added info here ;-) > > Signed-off-by: Badhri Jagan Sridharan > --- > Changelog since v1: > - fixed indentation > > include/trace/events/irq.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h > index ff8f6c0..dd8918c 100644 > --- a/include/trace/events/irq.h > +++ b/include/trace/events/irq.h > @@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry, > TP_STRUCT__entry( > __field( int, irq ) > __string( name, action->name ) > + __field( void*, handler ) Nit, you need a space between 'void' and '*'. -- Steve > ), > > TP_fast_assign( > __entry->irq = irq; > __assign_str(name, action->name); > + __entry->handler = action->handler; > ), > > - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name)) > + TP_printk("irq=%d name=%s handler=%pf", > + __entry->irq, __get_str(name), __entry->handler) > ); > > /**