Re: [PATCH v2] tools lib traceevent: install libtraceevent.a into libdir.

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 6 May 2015 22:29:15 +0200
Jiri Olsa <jolsa@redhat.com> wrote:

> On Wed, May 06, 2015 at 10:00:20AM +0000, Wang Nan wrote:
> > Before this patch, 'make install' installs libraries into bindir:
> > 
> >   $ make install DESTDIR=./tree
> >    INSTALL  trace_plugins
> >    INSTALL  libtraceevent.a
> >    INSTALL  libtraceevent.so
> >   $ find ./tree
> >    ./tree/
> >    ./tree/usr
> >    ./tree/usr/local
> >    ./tree/usr/local/bin
> >    ./tree/usr/local/bin/libtraceevent.a
> >    ./tree/usr/local/bin/libtraceevent.so
> >    ...
> > 
> > /usr/local/lib( or lib64) should be a better place.
> > 
> > This patch replaces 'bin' with libdir. For __LP64__ building, libraries
> > are installed to /usr/local/lib64. For other building, to
> > /usr/local/lib instead.
> > 
> > After applying this patch:
> > 
> >   $ make install DESTDIR=./tree
> >    INSTALL  trace_plugins
> >    INSTALL  libtraceevent.a
> >    INSTALL  libtraceevent.so
> >   $ find ./tree
> >    ./tree
> >    ./tree/usr
> >    ./tree/usr/local
> >    ./tree/usr/local/lib64
> >    ./tree/usr/local/lib64/libtraceevent.a
> >    ./tree/usr/local/lib64/traceevent
> >    ./tree/usr/local/lib64/traceevent/plugins
> >    ./tree/usr/local/lib64/traceevent/plugins/plugin_mac80211.so
> >    ./tree/usr/local/lib64/traceevent/plugins/plugin_hrtimer.so
> >    ...
> >    ./tree/usr/local/lib64/libtraceevent.so
> > 
> > Signed-off-by: Wang Nan <wangnan0@huawei.com>
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>
> 
> CC-ing Steven
> 

Thanks, looks fine to me.

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve