mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Michael Welling <mwelling@ieee.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects
Date: Thu, 7 May 2015 19:58:31 +0100	[thread overview]
Message-ID: <20150507185831.GQ22845@sirena.org.uk> (raw)
In-Reply-To: <1430955472-11409-1-git-send-email-mwelling@ieee.org>

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

On Wed, May 06, 2015 at 06:37:52PM -0500, Michael Welling wrote:
> This patch allows for GPIOs specified in the devicetree to be used as SPI
> chipselects on TI OMAP2 SoCs.
> 
> Tested on the AM3354.
> 
> Signed-off-by: Michael Welling <mwelling@ieee.org>
> ---
> v3: Switches driver to use transfer_one instead of transfer_one_message
> allowing the spi core to handle toggling GPIO chip selects if specified.

This is now two changes so it should be two patches, one converting to
transfer_one() and another adding the GPIO chip select support.  This
makes things easier to review and helps people trying to understand the
git history in the future (right now there's not even a mention of the
conversion to transfer_one() in the changelog).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-05-07 18:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 23:37 Michael Welling
2015-05-07 18:58 ` Mark Brown [this message]
2015-05-07 19:20   ` Michael Welling
2015-05-07 19:27     ` Mark Brown
2015-05-07 19:38       ` Michael Welling
2015-05-07 19:56         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150507185831.GQ22845@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mwelling@ieee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®