From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752391AbbEHI7c (ORCPT ); Fri, 8 May 2015 04:59:32 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:42811 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbbEHI71 (ORCPT ); Fri, 8 May 2015 04:59:27 -0400 Date: Fri, 8 May 2015 10:59:13 +0200 From: Peter Zijlstra To: Vikas Shivappa Cc: Vikas Shivappa , linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, matt.fleming@intel.com, will.auld@intel.com, peter.zijlstra@intel.com, h.peter.anvin@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 4/7] x86/intel_rdt: Implement scheduling support for Intel RDT Message-ID: <20150508085913.GC27504@twins.programming.kicks-ass.net> References: <1430530601-16319-1-git-send-email-vikas.shivappa@linux.intel.com> <1430530601-16319-5-git-send-email-vikas.shivappa@linux.intel.com> <20150502185131.GI3007@worktop.Skamania.guest> <20150506074835.GS23123@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2015 at 04:15:41PM -0700, Vikas Shivappa wrote: > >No. > > > >1) two arch hooks right after one another is FAIL > >1a) just 'fix' the existing hook > >2) current is cheap and easily obtainable without passing it as > > an argument > > will fix to just use an existing hook in finish_task_switch and > current(get_current) since the stack would already be changed .. > > Thanks, > Vikas > > >3) why do you need the hook in the first place? > >3a) why can't you put this in __switch_to()? This is very much x86 only > > code. ^ please also answer 3, why can't this go in __swtich_to()?