From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752757AbbEHJ6e (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 May 2015 05:58:34 -0400
Received: from mga03.intel.com ([134.134.136.65]:2524 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751409AbbEHJ6d (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 May 2015 05:58:33 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,390,1427785200"; 
   d="scan'208";a="725879208"
Date: Fri, 8 May 2015 12:56:21 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@ti.com>, David Cohen <david.a.cohen@linux.intel.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Baolu Lu <baolu.lu@linux.intel.com>, Paul Bolle <pebolle@tiscali.nl>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: =?utf-8?B?W82EUEFUQ0h2?= =?utf-8?Q?4?= 01/12] usb: add bus type
 for USB ULPI
Message-ID: <20150508095621.GA6154@kuha.fi.intel.com>
References: <1430979572-14768-1-git-send-email-heikki.krogerus@linux.intel.com>
 <1430979572-14768-2-git-send-email-heikki.krogerus@linux.intel.com>
 <20150507204604.GA28684@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150507204604.GA28684@kroah.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 07, 2015 at 10:46:04PM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 07, 2015 at 09:19:21AM +0300, Heikki Krogerus wrote:
> > +config USB_ULPI_BUS
> > +	bool "USB ULPI PHY interface support"
> 
> Can't we make this a module?

There is actually nothing preventing it.

I removed the possibility of building this as a module at one point
because... I guess just because a voice inside my head told me to do
so. Thanks for catching this one.

> > +	depends on USB_SUPPORT
> > +	help
> > +	  Say yes if you have ULPI PHY attached to your USB controller.
> 
> You need to put more information here as to what "ULPI" means, and how
> would anyone know if they have this type of thing attached to their USB
> controller.
> 
> You need to help users / distros out in letting them know if they should
> enable this or not.  As it is, I have no idea if I should even enable
> this on my systems...

OK.


Thanks,

-- 
heikki