From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932207AbbEKNoq (ORCPT ); Mon, 11 May 2015 09:44:46 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:34350 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932170AbbEKNof (ORCPT ); Mon, 11 May 2015 09:44:35 -0400 Date: Mon, 11 May 2015 22:43:17 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 3/3] perf report: Do not restrict -T option by other options Message-ID: <20150511134317.GA12220@danjae.kornet> References: <1431184784-30525-1-git-send-email-namhyung@kernel.org> <1431184784-30525-3-git-send-email-namhyung@kernel.org> <20150510172059.GB4587@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150510172059.GB4587@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Sun, May 10, 2015 at 02:20:59PM -0300, Arnaldo Carvalho de Melo wrote: > Em Sun, May 10, 2015 at 12:19:44AM +0900, Namhyung Kim escreveu: > > It seems there's no reason to suppress per-thread event stat by -T > > option when -s or -p option is used. Make it work with those options. > > Not applying on my perf/core branch, please check, I'll push what I have > now. It seems that it's because the commit e944ec2ca00f ("perf report: Fix -T/--threads option to work again") in the perf/urgent is not merged to the perf/core yet. I'll resend v2 soon. Thanks, Namhyung > > - Arnaldo > > > Signed-off-by: Namhyung Kim > > --- > > tools/perf/builtin-report.c | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > > index ee541ad555f2..0ae5eaaaf766 100644 > > --- a/tools/perf/builtin-report.c > > +++ b/tools/perf/builtin-report.c > > @@ -330,15 +330,14 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist, > > } > > > > if (sort_order == NULL && > > - parent_pattern == default_parent_pattern) { > > + parent_pattern == default_parent_pattern) > > fprintf(stdout, "#\n# (%s)\n#\n", help); > > > > - if (rep->show_threads) { > > - bool style = !strcmp(rep->pretty_printing_style, "raw"); > > - perf_read_values_display(stdout, &rep->show_threads_values, > > - style); > > - perf_read_values_destroy(&rep->show_threads_values); > > - } > > + if (rep->show_threads) { > > + bool style = !strcmp(rep->pretty_printing_style, "raw"); > > + perf_read_values_display(stdout, &rep->show_threads_values, > > + style); > > + perf_read_values_destroy(&rep->show_threads_values); > > } > > > > return 0; > > -- > > 2.3.7