From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753169AbbEKVSj (ORCPT ); Mon, 11 May 2015 17:18:39 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:33695 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbbEKVSh (ORCPT ); Mon, 11 May 2015 17:18:37 -0400 X-Originating-IP: 173.246.103.110 Date: Mon, 11 May 2015 14:18:25 -0700 From: Josh Triplett To: Paul Bolle Cc: Ingo Molnar , Andrew Morton , "Paul E. McKenney" , Michal Hocko , Vladimir Davydov , Johannes Weiner , Geert Uytterhoeven , Andy Lutomirski , Bertrand Jacquin , "Luis R. Rodriguez" , Iulia Manda , Pranith Kumar , Clark Williams , Mel Gorman , Randy Dunlap , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert Message-ID: <20150511211825.GA12080@jtriplet-mobl1> References: <20150511181327.GA1884@jtriplet-mobl1> <20150511202301.GA11897@jtriplet-mobl1> <1431378082.2398.97.camel@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431378082.2398.97.camel@x220> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 11, 2015 at 11:01:22PM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: > > I'd also like to factor the "if EXPERT" off of all the prompts and into a > > single scoped item wrapped around all of them, but kconfig doesn't have any way > > to do that. "menuconfig" is just a hint, with no matching "endmenu" and no > > implicit visibility; "menu" is scoped and has "visible if", but that would > > create a separate option containing a menu, rather than a menu under EXPERT's > > "Configure standard kernel features (expert users)". And "if EXPERT ... endif" > > produces a dependency, not a prompt-visibility condition. So I think this > > would require changes to the Kconfig language, to introduce either a scoped > > "visible if EXPERT ... endvisible" or similar, or a scoped version of > > menuconfig with a matching "endmenu" and implicit visibility (effectively a > > "menu" statement with attached "config" rather than a "config" with a hint > > "this might be a menu"). I'm leaning towards the latter. > > The behavior of menuconfig in this case is rather subtle. I must admit I > never noticed it. > > The "visible" option to menus is little used, and I'm not really > familiar with it. So, for what it's worth: would adding a new menu with > visible if EXPERT > > attached to it, and putting all current > prompt "Foo" if EXPERT > > entries in that menu roughly do what you want? Not quite. menu has a prompt but no associated symbol, so with current kconfig that would look like: config EXPERT bool "Configure standard kernel features (expert users)" ... menu "Some separate menu prompt here" visible if EXPERT ... various options that currently have if EXPERT on their prompts ... endmenu However, that would produce *two* entries under the "General setup" menu: a yes/no entry "Configure standard kernel features (expert users)" with no submenu, and a "Some separate menu prompt here" entry with a submenu but no '[ ]' for a yes/no option. Integrating the two (without using menuconfig's implicit "add stuff to submenu until an option's prompt doesn't depend on this symbol" magic) requires new a kconfig mechanism. - Josh Triplett