From: David Miller <davem@davemloft.net>
To: niklas.cassel@axis.com
Cc: f.fainelli@gmail.com, festevam@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, johan@kernel.org, niklass@axis.com,
stable@vger.kernel.org
Subject: Re: [PATCH v5] net: phy: micrel: Fix regression in kszphy_probe
Date: Tue, 12 May 2015 23:19:09 -0400 (EDT) [thread overview]
Message-ID: <20150512.231909.896139778564783277.davem@davemloft.net> (raw)
In-Reply-To: <1431416594-7758-1-git-send-email-niklass@axis.com>
From: Niklas Cassel <niklas.cassel@axis.com>
Date: Tue, 12 May 2015 09:43:14 +0200
> Don't do clock-mode-select if clk == NULL,
> since when building without CONFIG_HAVE_CLK,
> clk_get returns NULL and clk_get_rate returns 0.
>
> Doing clock-mode-select in this cause causes kszphy_probe to
> return -EINVAL and thus prevents the device from being probed.
>
> The original code (before regression) would return 0
> when building without CONFIG_HAVE_CLK.
>
> Cc: stable <stable@vger.kernel.org> # 3.18+
> Fixes: 1fadee0c3645 ("net/phy: micrel: Add clock support for
> KSZ8021/KSZ8031")
> Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>
> Reviewed-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Niklas Cassel <niklass@axis.com>
Applied, thank you.
prev parent reply other threads:[~2015-05-13 3:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 7:43 Niklas Cassel
2015-05-13 3:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512.231909.896139778564783277.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=niklass@axis.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome