From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753100AbbELHYI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 May 2015 03:24:08 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:40001 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752515AbbELHYG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 May 2015 03:24:06 -0400
Date: Tue, 12 May 2015 00:24:05 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: Christoph Hellwig <hch@infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dave Kleikamp <dave.kleikamp@oracle.com>, Jens Axboe <axboe@kernel.dk>,
        Zach Brown <zab@zabbo.net>, Maxim Patlasov <mpatlasov@parallels.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v3 1/4] fs: kiocb: introduce IOCB_DONT_DIRTY_PAGE flag
 for direct IO
Message-ID: <20150512072405.GB25438@infradead.org>
References: <1430932106-17451-1-git-send-email-ming.lei@canonical.com>
 <1430932106-17451-2-git-send-email-ming.lei@canonical.com>
 <20150507071618.GA7595@infradead.org>
 <CACVXFVOJH-7eKvpFe+9vN_0kyo8Thik+Mn75PTtmNhMdyjxoVw@mail.gmail.com>
 <20150511071909.GA19488@infradead.org>
 <CACVXFVNdKHMoDbFmdE4D8EfOtDxnr4RG24-z93+crx29+TpbXw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACVXFVNdKHMoDbFmdE4D8EfOtDxnr4RG24-z93+crx29+TpbXw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org
	See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 11, 2015 at 09:02:54PM +0800, Ming Lei wrote:
> > But those would be user pages.  Anyone who passes a kernel page doesn't
> 
> Inside kernel it is hard to say one page in page cache is kernel or
> user page, :-)

Inside the kernel it's easy to say that it's the caller business to
make sure we don't need to carry through hacks like this.

> > expect it do be dirtied for normal kernel interfaces.
> 
> Currently the coming direct IO introduced for loop should be the 1st direct
> read inside kernel, so there isn't the case of passing kernel pages, and
> obviously ITER_BVEC/ITER_KVEC doesn't mean the page is 'kernel' page.
> 
> Another direct IO inside kernel is __swap_writepage(), and it is still
> ITER_BVEC and user page. Maybe in the future swap_readpage()
> can use direct IO with BVEC too.


Swap will have very different rules to deal with page dirtying as it's
part of the VM subsystem.  Again, the caller will now better.