mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: wsa@the-dreams.de
To: Eddie Huang <eddie.huang@mediatek.com>
Cc: Sascha Hauer <kernel@pengutronix.de>,
	srv_heupstream@mediatek.com, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jean Delvare <jdelvare@suse.de>,
	David Box <david.e.box@linux.intel.com>,
	Doug Anderson <dianders@chromium.org>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	Max Schwarz <max.schwarz@online.de>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Anders Berg <anders.berg@avagotech.com>,
	Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
	Ray Jui <rjui@broadcom.com>, Simon Glass <sjg@chromium.org>,
	Wei Yan <sledge.yanwei@huawei.com>,
	Beniamino Galvani <b.galvani@gmail.com>,
	Xudong Chen <xudong.chen@mediatek.com>,
	Liguo Zhang <liguo.zhang@mediatek.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v7 3/3] I2C: mediatek: Add driver for MediaTek MT8173 I2C controller
Date: Tue, 12 May 2015 15:00:57 +0200	[thread overview]
Message-ID: <20150512130057.GC4447@schokonusskuchen.bad> (raw)
In-Reply-To: <1430901427-65146-4-git-send-email-eddie.huang@mediatek.com>

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

> +	if (i2c->irq_stat & I2C_RS_TRANSFER)
> +		dev_dbg(i2c->dev, "addr: %x, restart transfer interrupt.\n",
> +				msgs->addr);

I'd tend to leave out this debug message. But you may leave it if you
like. Rest of the patch looks okay.

Thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2015-05-12 13:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  8:37 [PATCH v7 0/3] ARM: mediatek: Add driver for Mediatek I2C Eddie Huang
2015-05-06  8:37 ` [PATCH v7 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx Eddie Huang
2015-05-12 12:37   ` wsa
2015-05-12 12:45     ` Sascha Hauer
2015-05-06  8:37 ` [PATCH v7 2/3] I2C: mediatek: Add driver for MediaTek I2C controller Eddie Huang
2015-05-12 12:58   ` wsa
2015-05-18  5:58     ` Eddie Huang
2015-05-18  6:37       ` Wolfram Sang
2015-05-18  7:42         ` Eddie Huang
2015-05-18  9:05           ` Wolfram Sang
2015-05-06  8:37 ` [PATCH v7 3/3] I2C: mediatek: Add driver for MediaTek MT8173 " Eddie Huang
2015-05-12 13:00   ` wsa [this message]
2015-05-07  7:39 ` [PATCH v7 0/3] ARM: mediatek: Add driver for Mediatek I2C Lee Jones
2015-05-07  7:54   ` Eddie Huang
2015-05-07  8:27     ` Lee Jones
2015-05-12 12:45 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512130057.GC4447@schokonusskuchen.bad \
    --to=wsa@the-dreams.de \
    --cc=anders.berg@avagotech.com \
    --cc=arnd@arndb.de \
    --cc=b.galvani@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=david.e.box@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=eddie.huang@mediatek.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jdelvare@suse.de \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=liguo.zhang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=max.schwarz@online.de \
    --cc=neelegup@linux.vnet.ibm.com \
    --cc=pawel.moll@arm.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sjg@chromium.org \
    --cc=sledge.yanwei@huawei.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=xudong.chen@mediatek.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®