From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexander Duyck <alexander.duyck@gmail.com>,
Joe Perches <joe@perches.com>, Jiri Pirko <jpirko@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] net: deinline netif_tx_stop_all_queues(), remove WARN_ON in netif_tx_stop_queue()
Date: Tue, 12 May 2015 09:00:17 -0700 [thread overview]
Message-ID: <20150512160016.GA3491@Alexeis-MBP.westell.com> (raw)
In-Reply-To: <1431371873-26969-1-git-send-email-dvlasenk@redhat.com>
On Mon, May 11, 2015 at 09:17:53PM +0200, Denys Vlasenko wrote:
> These functions compile to 60 bytes of machine code each.
> With this .config: http://busybox.net/~vda/kernel_config
> there are 617 calls of netif_tx_stop_queue()
> and 49 calls of netif_tx_stop_all_queues() in vmlinux.
>
> To fix this, remove WARN_ON in netif_tx_stop_queue()
> as suggested by davem, and deinline netif_tx_stop_all_queues().
>
> Change in code size is about 20k:
>
> text data bss dec hex filename
> 82426986 22255416 20627456 125309858 77813a2 vmlinux.before
> 82406248 22255416 20627456 125289120 777c2a0 vmlinux
nice code shrink. Looks good to me.
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
btw, in the future please say [PATCH net-next] as part of subject
to make it clear what tree this patch is going to.
next prev parent reply other threads:[~2015-05-12 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 19:17 Denys Vlasenko
2015-05-12 16:00 ` Alexei Starovoitov [this message]
2015-05-13 3:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512160016.GA3491@Alexeis-MBP.westell.com \
--to=alexei.starovoitov@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=dvlasenk@redhat.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®