From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933835AbbELVgn (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 May 2015 17:36:43 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:35771 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932697AbbELVgl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 May 2015 17:36:41 -0400
Date: Tue, 12 May 2015 23:36:26 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
        kan.liang@intel.com
Subject: Re: [PATCH] x86, perf: Allow time stamp for free running PEBSv3
Message-ID: <20150512213626.GU21418@twins.programming.kicks-ass.net>
References: <1431454308-582-1-git-send-email-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431454308-582-1-git-send-email-andi@firstfloor.org>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 12, 2015 at 11:11:48AM -0700, Andi Kleen wrote:
> +static unsigned long intel_pmu_free_running_flags(struct perf_event *event)
> +{
> +	unsigned long flags = x86_pmu.free_running_flags;
> +
> +	if (event->attr.clockid)

Made that: use_clockid, otherwise CLOCK_REALTIME would still allow this
(if it were allowed with hardware events).

> +		flags &= ~PERF_SAMPLE_TIME;
> +	return flags;
> +}