From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch v2] checkpatch: complain about GW-BASIC style label names
Date: Wed, 13 May 2015 15:12:32 +0100 [thread overview]
Message-ID: <20150513141232.GC7232@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150513123712.GA2798@mwanda>
On Wed, May 13, 2015 at 03:37:12PM +0300, Dan Carpenter wrote:
> GW-BASIC style label names are annoying so we can warn about that in
> checkpatch. The warnings look like:
>
> WARNING: 'fail2' isn't informative - prefer descriptive label names
> #267: FILE: ./sound/ppc/beep.c:267:
> + fail2: snd_ctl_remove(chip->card, beep_ctl);
>
> This generates slightly under 2000 new warnings. None of them are
> false positives.
And all of them are complete garbage. Please, stop forcing your personal
preferences upon the rest of us.
Any "fixes" of that sort in fs/*.c will be passed straight to /dev/null.
prev parent reply other threads:[~2015-05-13 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 11:21 [patch] " Dan Carpenter
2015-05-07 13:47 ` Joe Perches
2015-05-07 19:42 ` Dan Carpenter
2015-05-07 20:17 ` Joe Perches
2015-05-07 20:35 ` Joe Perches
2015-05-13 12:37 ` [patch v2] " Dan Carpenter
2015-05-13 13:16 ` David Sterba
2015-05-13 13:47 ` Dan Carpenter
2015-05-13 13:49 ` One Thousand Gnomes
2015-06-04 10:46 ` Dan Carpenter
2015-05-13 14:12 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513141232.GC7232@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=apw@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome