From: Andrew Morton <akpm@linux-foundation.org>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] lib/sort: Add 64 bit swap function
Date: Wed, 13 May 2015 14:46:59 -0700 [thread overview]
Message-ID: <20150513144659.15aea69ece3e3a9b9a2770f5@linux-foundation.org> (raw)
In-Reply-To: <55533561.4090001@bmw-carit.de>
On Wed, 13 May 2015 13:28:33 +0200 Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:
> On 05/13/2015 01:00 PM, Daniel Wagner wrote:
> > static int cmp_72(const void *a, const void *b)
> > {
> > u32 l = get_unaligned((u32 *) a);
> > u32 r = get_unaligned((u32 *) b);
> >
> > if (l < r)
> > return -1;
> > if (l > r)
> > return -1;
> > return 0;
> > }
>
> Argh, obviously wrong. Should I send a fix? The numbers do not change.
I fixed it up.
next prev parent reply other threads:[~2015-05-13 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87egml7sn6.fsf@rasmusvillemoes.dk>
2015-05-13 11:00 ` Daniel Wagner
2015-05-13 11:28 ` Daniel Wagner
2015-05-13 21:46 ` Andrew Morton [this message]
2015-05-15 7:22 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513144659.15aea69ece3e3a9b9a2770f5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®