From: David Miller <davem@davemloft.net>
To: sixiao@microsoft.com
Cc: kys@microsoft.com, haiyangz@microsoft.com,
devel@linuxdriverproject.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next,v2,1/1] hv_netvsc: use per_cpu stats to calculate TX/RX data
Date: Thu, 14 May 2015 22:49:58 -0400 (EDT) [thread overview]
Message-ID: <20150514.224958.144644873953606975.davem@davemloft.net> (raw)
In-Reply-To: <1431590425-23889-1-git-send-email-sixiao@microsoft.com>
From: Simon Xiao <sixiao@microsoft.com>
Date: Thu, 14 May 2015 01:00:25 -0700
> Current code does not lock anything when calculating the TX and RX stats.
> As a result, the RX and TX data reported by ifconfig are not accuracy in a
> system with high network throughput and multiple CPUs (in my test,
> RX/TX = 83% between 2 HyperV VM nodes which have 8 vCPUs and 40G Ethernet).
>
> This patch fixed the above issue by using per_cpu stats.
> netvsc_get_stats64() summarizes TX and RX data by iterating over all CPUs
> to get their respective stats.
>
> This v2 patch addressed David's comments on the cleanup path when
> netdev_alloc_pcpu_stats() failed.
>
> Signed-off-by: Simon Xiao <sixiao@microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Applied, thanks.
prev parent reply other threads:[~2015-05-15 2:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 8:00 Simon Xiao
2015-05-15 2:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514.224958.144644873953606975.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sixiao@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®