mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Len Brown <lenb@kernel.org>
Cc: "Jan H. Schönherr" <jschoenh@amazon.de>,
	"Thomas Gleixner" <tglx@linutronix.de>, "X86 ML" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Anthony Liguori" <aliguori@amazon.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, "Tim Deegan" <tim@xen.org>,
	"Gang Wei" <gang.wei@intel.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86: skip delays during SMP initialization similar to Xen
Date: Thu, 14 May 2015 08:44:07 +0200	[thread overview]
Message-ID: <20150514064407.GA9117@gmail.com> (raw)
In-Reply-To: <CAJvTdKmJr70DYAjDs-38PzEUSNpn1ncXxR_csFw3a724egHnZQ@mail.gmail.com>


* Len Brown <lenb@kernel.org> wrote:

> > [    0.404369] x86: Booting SMP configuration:
> ...
> > [    2.737884] x86: Booted up 4 nodes, 120 CPUs
> > [    2.743758] smpboot: Total of 120 processors activated (671097.18 BogoMIPS)
> >
> > (2.743758-0.404369) = 2.339389 for all 119 processors
> > /119 = .01965873109243697478 - lets call it 19ms each
> 
> For the record, the same (bare metal) box running latest tip boots
> 10ms/processor quicker
> than upstream Linux, as expected.   So this 120 processor box now
> boots 1.19 seconds faster, in total.
> 
> [    0.415969] x86: Booting SMP configuration:
> ...
> [    1.553658] x86: Booted up 4 nodes, 120 CPUs
> [    1.559173] smpboot: Total of 120 processors activated (671182.14 BogoMIPS)
> 
> 1.553658-0.415969 = 1.137689 - seconds to bring 119 processors on-line.
> ./119 = .00956041176470588235 -- 9.5ms per processor, down from 19.

Ok. I think we should be able to further speed that up.

> BTW. this time can be reduced by 7% (113 ms) by deleting 
> announce_cpu():
> 
> [    1.445815] x86: Booted up 4 nodes, 120 CPUs

so that kind of info looks pretty useful, especially when there's 
hangs/failures. I'm wondering what takes 113 msecs to print 120 CPUs - 
that's about 1 msec per a few chars of printk produced, seems 
excessive. Do you have any idea what's going on there? Does your 
system print to a serial console perhaps?

Thanks,

	Ingo

  reply	other threads:[~2015-05-14  6:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04  9:42 Jan H. Schönherr
2015-05-06  8:27 ` Ingo Molnar
2015-05-07  1:27   ` Len Brown
2015-05-07 10:23     ` Ingo Molnar
2015-05-12  8:03       ` Len Brown
2015-05-12  9:43         ` Ingo Molnar
2015-05-12  9:47         ` Ingo Molnar
2015-05-12 10:12           ` Borislav Petkov
2015-05-14  6:36         ` Len Brown
2015-05-14  6:44           ` Ingo Molnar [this message]
2015-05-16  8:46             ` Len Brown
2015-05-17  5:02               ` Ingo Molnar
2015-05-28  5:31                 ` Len Brown
2015-05-29  2:16                   ` Len Brown
2015-05-14  7:18           ` Len Brown
2015-05-14 14:25             ` "Jan H. Schönherr"
2015-05-14 17:57               ` Ingo Molnar
2015-05-16  9:07                 ` Len Brown
2015-05-17  5:26                   ` Ingo Molnar
2015-05-06 10:13 ` [tip:x86/apic] x86/smpboot: Skip " tip-bot for Jan H. Schönherr
2015-05-13  7:15 ` [tip:x86/apic] Revert f5d6a52f5111 ("x86/smpboot: Skip delays during SMP initialization similar to Xen") tip-bot for Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514064407.GA9117@gmail.com \
    --to=mingo@kernel.org \
    --cc=aliguori@amazon.com \
    --cc=gang.wei@intel.com \
    --cc=hpa@zytor.com \
    --cc=jschoenh@amazon.de \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tim@xen.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome