mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Scott Branden <sbranden@broadcom.com>
Cc: Jonathan Richardson <jonathar@broadcom.com>,
	Dmitry Torokhov <dtor@google.com>,
	Anatol Pomazau <anatol@google.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.
Date: Thu, 14 May 2015 11:31:44 +0100	[thread overview]
Message-ID: <20150514103144.GO2761@sirena.org.uk> (raw)
In-Reply-To: <5553E9FA.4070708@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On Wed, May 13, 2015 at 05:19:06PM -0700, Scott Branden wrote:

> The purpose of this mspi interface is to connect to NOR flash.  There are
> other SPI interfaces on the devices used to connect to other SPI devies.  We
> don't have any need to support full duplex slaves on this port (NOR have any
> hardware wired this way - pun realized after typing this).

Chip vendors often say this sort of thing and then get surprised by what
their users choose to do, and even if it only ever gets used with flash
all it would take is some new flash command which can use full duplex
for something.  Please write the code so it at least tries to handle
full duplex operation, if you can't test it fully that's not the end of
the world.  It doesn't look like it should be particularly difficult.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-05-14 10:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 17:38 [PATCH 0/2] Add " Jonathan Richardson
2015-05-12 17:38 ` [PATCH 1/2] ARM: dts: Add binding for " Jonathan Richardson
2015-05-12 18:38   ` Florian Fainelli
2015-05-12 17:38 ` [PATCH 2/2] spi: bcm-mspi: Add support " Jonathan Richardson
2015-05-12 18:46   ` Florian Fainelli
2015-05-12 19:17   ` Mark Brown
2015-05-13 23:49     ` Jonathan Richardson
2015-05-14  0:19       ` Scott Branden
2015-05-14 10:31         ` Mark Brown [this message]
2015-05-14 18:19           ` Scott Branden
2015-05-14 18:28             ` Florian Fainelli
2015-05-14 18:36               ` Scott Branden
2015-05-14 18:55                 ` Jonathan Richardson
2015-05-14 19:08             ` Mark Brown
2015-05-14 19:55               ` Jonathan Richardson
2015-05-14 20:12                 ` Mark Brown
2015-05-14 21:43                   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514103144.GO2761@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=anatol@google.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dtor@google.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jonathar@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®