mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: lizefan@huawei.com, cgroups@vger.kernel.org, mingo@redhat.com,
	peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] sched, cgroup: reorganize threadgroup locking
Date: Thu, 14 May 2015 11:17:42 -0400	[thread overview]
Message-ID: <20150514151742.GJ11388@htj.duckdns.org> (raw)
In-Reply-To: <20150514010913.GA4441@swordfish>

Hello, Sergey.

On Thu, May 14, 2015 at 10:09:13AM +0900, Sergey Senozhatsky wrote:
> > +static inline void threadgroup_change_begin(struct task_struct *tsk)
> >  {
> > -	down_write(&tsk->signal->group_rwsem);
> > +	might_sleep();
> 
> I think cgroup_threadgroup_change_begin()->down_read() already does
> might_sleep() check.

Sure but it's a layering thing.  threadgroup_change_begin() should be
called from a blockable context whether the hook users actually make
use of it or not.  e.g. We want might_sleep() even when
!CONFIG_CGROUP.

Thanks.

-- 
tejun

  reply	other threads:[~2015-05-14 15:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 20:35 [PATCHSET] cgroup, sched: restructure threadgroup locking and replace it with a percpu_rwsem Tejun Heo
2015-05-13 20:35 ` [PATCH 1/3] sched, cgroup: reorganize threadgroup locking Tejun Heo
2015-05-14  1:09   ` Sergey Senozhatsky
2015-05-14 15:17     ` Tejun Heo [this message]
2015-05-13 20:35 ` [PATCH 2/3] sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem Tejun Heo
2015-05-19 15:16   ` Peter Zijlstra
2015-05-19 15:51     ` Tejun Heo
2015-05-20 10:05       ` Zefan Li
2015-05-21 20:39         ` Tejun Heo
2015-05-24  2:35           ` Zefan Li
2015-05-13 20:35 ` [PATCH 3/3] cgroup: simplify threadgroup locking Tejun Heo
2015-05-18 16:34 ` [PATCHSET] cgroup, sched: restructure threadgroup locking and replace it with a percpu_rwsem Tejun Heo
2015-05-18 20:06   ` Peter Zijlstra
2015-05-27  0:34 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514151742.GJ11388@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®